Skip to content

Add local clear in tangency computer#1833

Open
JacquesOlivierLachaud wants to merge 8 commits intoDGtal-team:mainfrom
JacquesOlivierLachaud:AddLocalClearInTangencyComputer
Open

Add local clear in tangency computer#1833
JacquesOlivierLachaud wants to merge 8 commits intoDGtal-team:mainfrom
JacquesOlivierLachaud:AddLocalClearInTangencyComputer

Conversation

@JacquesOlivierLachaud
Copy link
Copy Markdown
Member

PR Description

Minor update in TangencyComputer. Allows for local clear of the ShortestPath computation object, which is faster than a global clear when you are computing bounded/local shortest paths.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

Copy link
Copy Markdown
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Could you add a changelog entry?

@JacquesOlivierLachaud
Copy link
Copy Markdown
Member Author

Still working on it. I will let you know when it is ready.

@dcoeurjo
Copy link
Copy Markdown
Member

👍 can you update the branch from the master and install the pre-commit hooks ? (see CONTRIBUTING.md)

@JacquesOlivierLachaud
Copy link
Copy Markdown
Member Author

Ok. I have installed pre-commit and used it on the modified files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants